Uploaded image for project: 'SimplyE 2.0'
  1. SimplyE 2.0
  2. SIMPLY-3001

Refactor borrowing task

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Done
    • Icon: Medium Medium
    • 5.0.10 (Android)
    • Android
    • None
    • SIMPLY S18 August 18 - Sep 1, SIMPLY S19 September 1 - 15, SIMPLY 22 Oct 14 - Oct 27, SIMPLY S20 September 15 - 29, SIMPLY S21 Sep 29 - Oct 13, SIMPLY S23 Oct 27 - Nov 10

      The code for borrowing books on Android has grown to ~1800 lines in a single file. The code is extremely well unit-tested, but it tries to do too much and is too hard to maintain. We now need to add yet another code path to this for SAML support, and it's too much!

      We need to refactor the borrow task into separate borrow and fulfill tasks, and separate the fulfill tasks into classes for each of the workflows we support (bearer token, ACS, audio book, bundled, etc).

        1.
        		 Introduce book format support API Sub-task Done Joseph Dalton
        2.
        		 Remove format filtering from OPDS code Sub-task Done Joseph Dalton
        3.
        		 Implement direct-download borrowing subtask Sub-task Done Joseph Dalton
        4.
        		 Implement OPDS loan creation subtask Sub-task Done Joseph Dalton
        5.
        		 Implement ACS fulfillment subtask Sub-task Done Joseph Dalton
        6.
        		 Implement audio book fulfillment subtask Sub-task Done Joseph Dalton
        7.
        		 Integrate all of the new borrow subtasks Sub-task Done Joseph Dalton

            markraynsford Mark Raynsford
            markraynsford Mark Raynsford
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: