Uploaded image for project: 'SimplyE 2.0'
  1. SimplyE 2.0
  2. SIMPLY-2975

Improve MyBooksDownloadCenter::failDownloadForBook reports on Crashlytics

XMLWordPrintable

    • SIMPLY S17 August 4 - 18, SIMPLY S18 August 18 - Sep 1, SIMPLY S19 September 1 - 15, SIMPLY 22 Oct 14 - Oct 27, SIMPLY S20 September 15 - 29, SIMPLY S21 Sep 29 - Oct 13
    • 5

      https://console.firebase.google.com/project/simplye-nypl/crashlytics/app/ios:org.nypl.labs.SimplyE/issues/05b284711b51e72dcd71796a366a960e

      This error group collates different kinds of book download errors and there are insufficient details to distinguish them. We should add more context to the error report, and possibly the problem document if available.

      We should make clear:

      • which distributor is involved, possibly even surface that to the event title
      • if this is just a network error / timeout (<-- this will be done as part of SIMPLY-2985)
      • if it's a fulfillment error
      • ??

      If SimplyE decides on its own that a book download has failed, it should provide a similar rationale when it reports the problem, so that we can distinguish in Crashlytics between superficially similar problems.

      • If the rationale for "Overdrive book download failed" is "couldn't parse the manifest", and you also provide the manifest (or some information about it) then we can look at the manifest (or the information) and hopefully distinguish between network problems, vendor problems, and circulation manager problems.
      • If the rationale is "network communication error" then we can say this is almost certainly a client-side network problem.
      • If the rationale is suspect, as "this doesn't look like an audiobook" was, then explicitly stating it will make it easier to catch a SIMPLY-2962 type bug in code review.

            JosephDalton Joseph Dalton
            EttorePasquini Ettore Pasquini
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: