Currently some of our error buckets on Crashlytics include reports caused by something for which we cannot do anything about. For example this report includes reasons like:

• request timeouts
  • Error Domain=NSURLErrorDomain Code=-1001
• unsupported/empty URL (usually this is a transient error)
  • Error Domain=NSURLErrorDomain Code=-1002
• internet connection offline
  • Error Domain=NSURLErrorDomain Code=-1009

other to look for:

• download task canceled
  • NSURLErrorCancelled = -999
• network connection lost
  • NSURLErrorNetworkConnectionLost = -1005
• user canceled authentication
  • NSURLErrorUserCancelledAuthentication = -1012

(full list in CFNetworkErrors.h and NSURLError.h)

Ideally we should detect these errors and group them in their own separate report as a warning rather than an error, because they just create noise in the sea of real errors that require fixing.

Refactor all methods in NYPLErrorLogger that receive a NSError as an input param.