Uploaded image for project: 'SimplyE 2.0'
  1. SimplyE 2.0
  2. SIMPLY-4279

[SimplyE] Check for nil Publication.baseURL before initializing EPUBNavigatorViewController

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Medium Medium
    • None
    • None
    • eReading S3 Jan 30 - Feb 13, eReading S4 Feb 13 - Feb 27, eReading S5 Feb 27 - Mar 12, eReading S6 Mar 12 - Mar 26, eReading S7 Mar 26 - Apr 9, eReading S8 Apr 9 - Apr 23, eReading S9 Apr 23 - May 7
    • 3

      This is an alternative approach to IOS-629

       

      We can avoid the new Readium crash (crash details here https://nypl.slack.com/archives/C028S15RV/p1703228451823569 ) by checking baseURL before passing it to the broken initializer. This is the fix Readium team suggested to us - https://readium.slack.com/archives/C4APPBHUZ/p1703850941953469?thread_ts=1703630117.421349&cid=C4APPBHUZ 

      While we can make a PR to Readium code to be less strict, we can apply the immediate fix without needing to wait for external partners to accept our PR and push a release. A new Readium release with this fix seems unlikely anyways according to the lead dev -  https://readium.slack.com/archives/C4APPBHUZ/p1704737289531519?thread_ts=1703630117.421349&cid=C4APPBHUZ 

       

            EttorePasquini Ettore Pasquini
            russellcullen Russell Cullen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: