The Odilo circulation API was modeled after the Overdrive circulation API. I thought that was because the Odilo web API had the same architecture as the Overdrive web API, but it turns out that's not true. The Odilo web API uses OAuth to negotiate a global token, but once you have the global token you can act on behalf of any patron.

There's a significant amount of code regarding the creation of patron tokens which doesn't work (because the Odilo web API doesn't actually have a concept of 'patron token'), and which isn't used in the code that actually acts on behalf of patrons.

Hopefully this code can simply be removed.

Also, there's no reason to split up the Odilo circulation API between core and circulation. That's another thing that was copied from Overdrive (where it does make sense, since the metadata wrangler needs to be able to use the Overdrive API).